That device almost ruined the book for me, because so much of it is William Goldman telling us how great the framed story is. He uses the conceit of a fictional author, S. Morgenstern, but since in fact Goldman wrote the story (the "best parts version"), that much self-praise is a little off-putting.
The first example I thought of was the Edgar Rice Burroughs adventure The Land That Time Forgot. The main story is a manuscript in a Thermos bottle, found in the ocean. The framing-story narrator, before presenting the text of the manuscript, assures us that "you will forget me in two pages", or something like that (which is true).
Agreed on TPB. He really overplayed his hand as a clever author... particularly in the anniversary edition I read, where he really twisted things by claiming "Morgenstern" was relating actual historical characters from his made-up countries, and got the family estate involved in stifling the "sequel." The movie did good to dial it back to just a grandfather reading the fairy tale to the kid, without the extra baggage.
Still a classic despite that, though.
IIRC, framing devices used to be very common in Burroughs's day; often it seemed to be a gathering of friends while one man told a story that was the novel/short, a framing device that really contributed little to the tale but was so common I don't think writers of the day questioned using it.
As for ones that haven't been mentioned... as someone mentioned upthread, I've been known to forget all about framing devices, particularly when they add little value to the tale, and must be reminded when they were used. I believe that Robin Hobb's
Assassin's Apprentice was framed, a tale told by an older MC of his formative years.
For a framing device that worked well and actually contributed, with a great ending of its own, Sara Gruen's
Water for Elephants is narrated by the MC when he's in his 90's in a nursing home... but he still has his own story to contribute.
And ages ago I read a book that totally spoiled itself with its framing device, giving away its own ending - R. A. MacAvoy's
The Lens of the World, IIRC, compiled from a serialized story. The thing was, the story wasn't finished, it was just Book 1, yet the framing device gave away how things ended in the first book. (I believe I read somewhere later on that the framed conclusion was forced on the story when it was converted to a novel, by editors who didn't want readers confused by the fact that it was just the first part of a series... 'cause, you know, us fantasy readers totally are incapable of handling it when a story is told over multiple installments... Don't quote me on that, though, 'cause I may be jumbling it in my head with another story.) In any event, I really didn't like it so I never read on; the lousy spoilery ending was just the final nail in that coffin.